Bug 209 - When exporting to object file, disallow unresolved symbols that are used as a part of an expression
Summary: When exporting to object file, disallow unresolved symbols that are used as a...
Status: RESOLVED FIXED
Alias: None
Product: RMAC
Classification: Unclassified
Component: Core (show other bugs)
Version: unspecified
Hardware: All All
: Normal enhancement
Assignee: Shamus Hammons
URL:
Depends on:
Blocks:
 
Reported: 2022-09-27 15:23 CDT by ggn
Modified: 2022-12-21 16:50 CST (History)
1 user (show)

See Also:

Attachments
The patches! (1.92 KB, patch)
2022-10-17 11:52 CDT, ggn 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ggn 2022-09-27 15:23:45 CDT 
After the discussion that happened here (https://forums.atariage.com/topic/234634-rmacrln/?do=findComment&comment=5129447) I think it would be helpful for everyone if we added some checks against that.
Comment 1 ggn 2022-10-17 11:52:47 CDT 
Created attachment 199 [details]
The patches!

So here we go, this was apparently quite straightforward to do, just add a check during the fixups.

I tested the fix with the following source (also, regression suite passed without hiccups):


    .globl  external_value
    .globl  external_value_2

    move.l  #external_value,d1      ;should be ok
    move.l  #external_value<<11,d0  ;this should produce an error
    lsl.l   #8,d1
    lsl.l   #3,d1

    move.l  #external_value_2,d0    ;should be ok
Comment 2 Shamus Hammons 2022-12-21 16:50:03 CST 
Thanks for the patch!  :-)