Bug 202 - PACK and UNPACK GPU RISC instructions are swapped
Summary: PACK and UNPACK GPU RISC instructions are swapped
Status: RESOLVED FIXED
Alias: None
Product: RMAC
Classification: Unclassified
Component: Core (show other bugs)
Version: unspecified
Hardware: PC Linux
: Normal enhancement
Assignee: Shamus Hammons
URL:
Depends on:
Blocks:
 
Reported: 2022-06-13 19:46 CDT by James Jones
Modified: 2022-06-29 10:36 CDT (History)
1 user (show)

See Also:

Attachments
Fix (1.07 KB, patch)
2022-06-13 19:46 CDT, James Jones 		Details
Test case demonstrating the bug (3.00 KB, text/plain)
2022-06-13 19:48 CDT, James Jones 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Jones 2022-06-13 19:46:54 CDT 
Created attachment 180 [details]
Fix

The GPU-specific PACK and UNPACK instructions share opcode 63. PACK is chosen by encoding '0' in the source operand, and UNPACK is chosen by encoding '1' in the source operand. RMAC had the magic source operand values reversed.
Comment 1 James Jones 2022-06-13 19:48:15 CDT 
Created attachment 181 [details]
Test case demonstrating the bug

Attaching a trivial test case. The screen will be yellow when it's working, red when it's not.
Comment 2 Shamus Hammons 2022-06-29 10:36:16 CDT 
Thanks for the patch!  :-)