| Summary: | Disabled code gives errors when it shouldn't | ||
|---|---|---|---|
| Product: | RMAC | Reporter: | ggn <ggnkua> |
| Component: | Core | Assignee: | Shamus Hammons <jlhamm> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | jlhamm |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | PC | ||
| OS: | Linux | ||
I agree that this is disconcerting, as I've had this bite me a few times in development of Project X ("whaddya mean there's an error in the disabled section???"). Just haven't taken the time to look at what would be required. Looks like it should be a simple thing, though.
Oops, didn't notice this issue! So an attempt to fix this was committed in #199, but this still doesn't pass the test source mentioned in this ticket. A better approach is required :) |
Consider the following code: if 0 sdojfosdjfdoj dfsjodfjoisdjf sdfpsodifpsd { + } 20-399304-92034 endif The 3 lines after the "if 0" are fine but the other 4 give out a "Error: syntax error; expected symbol". This certainly comes from procln.c and the check that first token must be a symbol, but does not skip that when "disabled" is true. IMO we should add a "||disabled" check in both places this check happens. I really can't see a side effect adding this, happy to discuss it thought.